Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Detect unpinned git submodules in GH PR checks #5627

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[CI] Detect unpinned git submodules in GH PR checks #5627

merged 1 commit into from
Nov 18, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 18, 2024 •
edited
Loading

/cc @jack-berg @svrnm

The PR contains a seeded error (submodule update w/o a pin ID change) to test the detection of such a situation.

@chalin chalin added the CI/infra CI & infrastructure label Nov 18, 2024
@chalin chalin requested a review from a team as a code owner November 18, 2024 18:12
@opentelemetrybot opentelemetrybot requested a review from a team November 18, 2024 18:12
@chalin chalin marked this pull request as draft November 18, 2024 18:12
@chalin chalin mentioned this pull request Nov 18, 2024
Merged
@chalin chalin force-pushed the chalin-im-detect-unpinned-submodules-2024-11-18 branch 4 times, most recently from c7d6e8a to cbcf079 Compare November 18, 2024 18:25
@chalin
Copy link
Contributor Author

chalin commented Nov 18, 2024

Unpinned submodule version detected ✅, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11898688134/job/33155706203?pr=5627#step:7:40:

> _diff:fail
> git diff --name-only --exit-code || exit 1

content-modules/opentelemetry-java-examples
Error: Process completed with exit code 1.

@chalin chalin force-pushed the chalin-im-detect-unpinned-submodules-2024-11-18 branch from cbcf079 to 7c492ce Compare November 18, 2024 18:28
@chalin chalin force-pushed the chalin-im-detect-unpinned-submodules-2024-11-18 branch from 7c492ce to 47a3929 Compare November 18, 2024 18:30
@chalin chalin marked this pull request as ready for review November 18, 2024 18:35
tiffany76
tiffany76 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin merged commit b2dc0d6 into open-telemetry:main Nov 18, 2024
17 checks passed
@chalin chalin deleted the chalin-im-detect-unpinned-submodules-2024-11-18 branch November 18, 2024 18:43
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
@chalin @drewby
[CI] Detect unpinned git submodules in GH PR checks (open-telemetry#5627
0adbf1e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @svrnm @tiffany76